Re: [PATCH v8 00/14] power: bq24257: Add support for bq24250/bq24251
From: Andreas Dannenberg <hidden>
Date: 2015-10-01 16:53:48
Also in:
linux-devicetree, linux-pm
On Thu, Oct 01, 2015 at 04:58:47AM +0200, Sebastian Reichel wrote:
Hi, On Mon, Sep 28, 2015 at 05:33:48PM -0500, Andreas Dannenberg wrote:quoted
This patch series extends the driver to also support bq24250/bq24251. The bq24250/251/257 devices have a very similar feature set and are virtually identical from a control register point of view so it made sense to extend the existing driver rather than submitting a new driver. In addition to the new device support the driver is also extended to allow access to some device features previously hidden. Basic and potentially dangerous charger config parameters affecting the actual charging of the Li-Ion battery are only configurable through firmware rather than sysfs properties. However some newly introduced properties are exposed through sysfs properties as access to them may be desired from userspace. For example, it is now possible to manually configure the maximum current drawn from the input source to accommodate different chargers (0.5A, 1.5A, 2.0A and so on) based on system knowledge a userspace application may have rather than rely on the auto-detection mechanism that may not work in all possible scenarios.Thanks, I queued all remaining patches except for
Sebastian, I just pulled your tree and re-ran some of my tests. Looks like everything is still working as it should. Thanks again for your help reviewing. Same goes for Krzysztof and Laurentiu -- thanks for your time and feedback too.
quoted
power: bq24257: Add platform data based initializationI'm still not convinced, that it should be added without any consumer in the mainline kernel.
Well I tried to make my case (giving access to the largest audience possible). If you don't want to include it that's fine. I guess it can always get added if a specific need arises... For future reference here is the link to the latest version of that patch: http://marc.info/?l=linux-pm&m=144347973708093&w=2 -- Andreas Dannenberg Texas Instruments Inc