Re: [PATCH v4 09/79] via_drm.h: don't include non-existing via_drmclient.h
From: Emil Velikov <hidden>
Date: 2015-10-21 15:01:52
Also in:
dri-devel, lkml
On 15 October 2015 at 06:55, Mikko Rapeli [off-list ref] wrote:
quoted hunk ↗ jump to hunk
Fixes compiler error: drm/via_drm.h:36:27: fatal error: via_drmclient.h: No such file or directory Signed-off-by: Mikko Rapeli <redacted> --- include/uapi/drm/via_drm.h | 3 --- 1 file changed, 3 deletions(-)diff --git a/include/uapi/drm/via_drm.h b/include/uapi/drm/via_drm.h index 8b0533c..d19c0e2 100644 --- a/include/uapi/drm/via_drm.h +++ b/include/uapi/drm/via_drm.h@@ -33,9 +33,6 @@ #ifndef _VIA_DEFINES_ #define _VIA_DEFINES_ -#ifndef __KERNEL__ -#include "via_drmclient.h" -#endif
Now this one is messy. If we remove it, existing userspace [0] won't be able to build. As they don't include the above header where needed, but instead rely on via_drm.h. Despite the fact that each user provides its own copy of via_drmclient.h. There is some very old hardware/software involved so I'm not sure how much of a real issue this patch will be. If the maintainers decide to pick it up, let me know and I'll roll a fix for the ddx. -Emil [0] There are two users afaict - the via dri mesa module and xf86-video-via. With the former nuked some 5 years ago with mesa commit e4344161bde2e24fcfba65d30d58f087bd8bf94d _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel