Thread (20 messages) flat view 20 messages, 4 authors, 2015-10-06

Re: [PATCH v4 3/5] PCI: Handle IORESOURCE_PCI_FIXED when sizing and assigning resources.

From: Yinghai Lu <yinghai@kernel.org>
Date: 2015-10-03 03:00:24
Also in: linux-pci, lkml

On Fri, Oct 2, 2015 at 4:38 PM, David Daney [off-list ref] wrote:
On 10/02/2015 04:14 PM, Yinghai Lu wrote:
quoted
https://patchwork.kernel.org/patch/7304371/
[v6,06/53] PCI: Claim fixed resource during remove/rescan path

This one is interesting, but I don't think it will work.

pci_claim_resource() calls pci_find_parent_resource(), which will fail in
important use cases.

It is perfectly legal for a bridge provisioned by EA to not specify any
resources.  In this case we must walk up the bus tree until we find
something that contains the device resource, and can thus be a parent.

That is a big part of what my patch is doing.
looks we need another resource flags for EA in addition to
FIXED as it could out side of bridge MMIO range.
As for the merits of assigning fixed resources from the FINAL fixup, rather
than in __pci_bus_assign_resources(), I am unsure.
usually __pci_bus_assign_resources() is used for unassigned one. so
I don't want it mixed with request resource there.

Thanks

Yinghai
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help