Re: [PATCH v10 44/46] nfs: Add richacl support
From: Andreas Gruenbacher <agruenba@redhat.com>
Date: 2015-10-12 19:49:17
Also in:
linux-cifs, linux-ext4, linux-fsdevel, linux-nfs, linux-xfs, lkml
Anna, On Mon, Oct 12, 2015 at 4:39 PM, Anna Schumaker [off-list ref] wrote:
I'm not a fan of the "one giant function" approach. Is there any way to split richacl_from_nfs4_acl() into several smaller functions?
sure, parsing the usr/group identifier could be put in a separate function, for example. That function cannot stay as it is right now anyway --- we really need idmapper to tell us when an identifier string cannot be mapped to a uid or gid so that we can preserve that identifier. Thanks, Andreas _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs