Re: [RFC v7 24/41] richacl: Set the other permissions to the other mask

2015-09-23 16:03 GMT+02:00 J. Bruce Fields [off-list ref]:

On Sat, Sep 05, 2015 at 12:27:19PM +0200, Andreas Gruenbacher wrote:

quoted

+static int
+richacl_set_other_permissions(struct richacl_alloc *alloc)
+{
+     struct richacl *acl = alloc->acl;
+     unsigned int x = RICHACE_POSIX_ALWAYS_ALLOWED;
+     unsigned int other_mask = acl->a_other_mask & ~x;
+     struct richace *ace = acl->a_entries + acl->a_count - 1;
+
+     if (!(other_mask &&
+           (acl->a_flags & RICHACL_WRITE_THROUGH) &&
+           (acl->a_flags & RICHACL_MASKED)))
+             return 0;

By the way, I think this is only called after checking MASKED--so the
MASKED check here could be a WARN_ON, or could just be dropped.  Ditto
for the following patch.

Hmm, yes. I'll drop that.

Thanks,
Andreas
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html