Re: [RFC v7 25/41] richacl: Isolate the owner and group classes

2015-09-22 21:02 GMT+02:00 J. Bruce Fields [off-list ref]:

On Sat, Sep 05, 2015 at 12:27:20PM +0200, Andreas Gruenbacher wrote:

quoted

+      * Compute the permissions already denied to @who.

I'm not sure, but may be worth commenting on the lack of everyone denies
here as you do in a couple places below.

Okay.

As in the owner case, I think a goto would simplify the logic a little.

Yep, I'll clean that up.

quoted

+             /*
+              * Start from the entry before the trailing everyone@ allow
+              * entry.  We will not hit everyone@ entries in the loop.

May as well skip the check below, in that case?

Indeed. You can almost tell from those few leftovers how the code has
evolved over time :)

Thanks,
Andreas
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html