Re: [PATCH v8 44/55] [media] uapi/media.h: Add MEDIA_IOC_G_TOPOLOGY ioctl
From: Hans Verkuil <hidden>
Date: 2015-09-11 14:00:00
Also in:
linux-media
Possibly related (same subject, not in this thread)
- 2015-08-31 · Re: [PATCH v8 44/55] [media] uapi/media.h: Add MEDIA_IOC_G_TOPOLOGY ioctl · Mauro Carvalho Chehab <hidden>
- 2015-08-31 · Re: [PATCH v8 44/55] [media] uapi/media.h: Add MEDIA_IOC_G_TOPOLOGY ioctl · Hans Verkuil <hidden>
- 2015-08-30 · [PATCH v8 44/55] [media] uapi/media.h: Add MEDIA_IOC_G_TOPOLOGY ioctl · Mauro Carvalho Chehab <hidden>
On 09/06/2015 02:03 PM, Mauro Carvalho Chehab wrote:
Add a new ioctl that will report the entire topology on one go. Signed-off-by: Mauro Carvalho Chehab <redacted>
Acked-by: Hans Verkuil <redacted> I do have one suggestion: media_v2_interface, media_v2_pad and media_v2_link all have a 'flags' field, but it is not clear from the code in the header which flag #defines are used for which struct. Perhaps a few comments would help with that.
quoted hunk ↗ jump to hunk
diff --git a/include/uapi/linux/media.h b/include/uapi/linux/media.h index a1bd7afba110..b17f6763aff4 100644 --- a/include/uapi/linux/media.h +++ b/include/uapi/linux/media.h
<snip>
+
+struct media_v2_pad {
+ __u32 id;
+ __u32 entity_id;
+ __u32 flags;
+ __u16 reserved[9];Strange odd number here for no clear reason. Perhaps use 8 or 10 instead? Anyway, you have my Ack. Regards, Hans