Re: [PATCH v7 09/15] power: bq24257: Add SW-based approach for Power Good determination
From: Sebastian Reichel <hidden>
Date: 2015-09-27 20:20:26
Also in:
linux-devicetree, linux-pm
Hi, On Fri, Sep 25, 2015 at 10:54:14AM -0500, Andreas Dannenberg wrote:
quoted hunk
@@ -651,15 +670,18 @@ static int bq24257_power_supply_init(struct bq24257_device *bq) return PTR_ERR_OR_ZERO(bq->charger); } -static int bq24257_pg_gpio_probe(struct bq24257_device *bq) +static void bq24257_pg_gpio_probe(struct bq24257_device *bq) { - bq->pg = devm_gpiod_get_index(bq->dev, BQ24257_PG_GPIO, 0, GPIOD_IN); + bq->pg = devm_gpiod_get_optional(bq->dev, BQ24257_PG_GPIO, GPIOD_IN); + if (IS_ERR(bq->pg)) { - dev_err(bq->dev, "could not probe PG pin\n"); - return PTR_ERR(bq->pg); + dev_err(bq->dev, "error probing PG pin\n"); + bq->pg = NULL; + return; }
You should handle -EPROBE_DEFER here. -- Sebastian
Attachments
- signature.asc [application/pgp-signature] 819 bytes