Re: [PATCH v6 03/14] power: bq24257: Streamline input current limit setup

On Fri, Sep 25, 2015 at 04:23:03PM +0300, Laurentiu Palcu wrote:

On Thu, Sep 24, 2015 at 10:26:47PM -0500, Andreas Dannenberg wrote:
[...]

quoted

-	if (reset_iilimit) {
+		/* reset input current limit */
 		ret = bq24257_field_write(bq, F_IILIMIT, IILIMIT_500);
 		if (ret < 0)
 			goto error;
-	} else if (config_iilimit) {
-		schedule_delayed_work(&bq->iilimit_setup_work,
+	} else if (!old_state.power_good) {
+		dev_dbg(bq->dev, "Power inserted\n");
+		if (bq->iilimit_autoset_enable)

iilimit_autoset_enable is introduced in patch 6. If we ever need to
bisect this code, this patch will fail to build.

Good catch!! I want to fix this and retest/resubmit (and put in the
suggestion from your other email too). I know it's a lot of traffic but
it should be done right :)

Regards,
Andreas
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html