Re: [RFC v2 09/18] mm/huge_page: Convert khugepaged() into kthread worker API
From: Tejun Heo <tj@kernel.org>
Date: 2015-09-22 20:26:13
Also in:
linux-mm, lkml
Hello, On Mon, Sep 21, 2015 at 03:03:50PM +0200, Petr Mladek wrote:
+static int khugepaged_has_work(void)
+{
+ return !list_empty(&khugepaged_scan.mm_head) &&
+ khugepaged_enabled();
+}Hmmm... no biggie but this is a bit bothering.
quoted hunk ↗ jump to hunk
@@ -425,7 +447,10 @@ static ssize_t scan_sleep_millisecs_store(struct kobject *kobj, return -EINVAL; khugepaged_scan_sleep_millisecs = msecs; - wake_up_interruptible(&khugepaged_wait); + if (khugepaged_has_work()) + mod_delayed_kthread_work(khugepaged_worker, + &khugepaged_do_scan_work, + 0);
What's wrong with just doing the following? if (khugepaged_enabled()) mod_delayed_kthread_work(...); Thanks. -- tejun -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>