Thread (12 messages) flat view 12 messages, 3 authors, 2015-10-14
STALE3993d REVIEWED: 4 (3M)

Revision v5 of 3 in this series; 2 review trailers.

Revisions (3)
  1. v3 [diff vs current]
  2. v5 current
  3. v8 [diff vs current]

[PATCH v5 5/9] vfs: Copy shouldn't forbid ranges inside the same file

From: Anna Schumaker <hidden>
Date: 2015-09-30 17:27:14
Also in: linux-btrfs, linux-fsdevel, linux-nfs
Subsystem: filesystems (vfs and infrastructure), the rest · Maintainers: Alexander Viro, Christian Brauner, Linus Torvalds

This is perfectly valid for BTRFS and XFS, so let's leave this up to
filesystems to check.

Signed-off-by: Anna Schumaker <redacted>
Reviewed-by: David Sterba <dsterba@suse.com>
Reviewed-by: Darrick J. Wong <redacted>
---
 fs/read_write.c | 4 ----
 1 file changed, 4 deletions(-)
diff --git a/fs/read_write.c b/fs/read_write.c
index f3d6c48..8e7cb33 100644
--- a/fs/read_write.c
+++ b/fs/read_write.c
@@ -1371,10 +1371,6 @@ ssize_t vfs_copy_file_range(struct file *file_in, loff_t pos_in,
 	    file_in->f_path.mnt != file_out->f_path.mnt)
 		return -EXDEV;
 
-	/* forbid ranges in the same file */
-	if (inode_in == inode_out)
-		return -EINVAL;
-
 	if (len == 0)
 		return 0;
 
-- 
2.6.0
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help