Re: [RFC v6 10/40] richacl: Permission check algorithm

On Sat, Aug 29, 2015 at 12:06:22AM +0200, Andreas Grünbacher wrote:

2015-08-28 23:49 GMT+02:00 J. Bruce Fields [off-list ref]:

quoted

On Tue, Aug 04, 2015 at 01:53:08PM +0200, Andreas Gruenbacher wrote:

quoted

+             /*
+              * We don't care which class the process is in when the acl is
+              * not masked.
+              */
+             in_owner_or_group_class = 1;

So why bother setting it at all, then?  Oh, I see, it lets you break out
of the loop below earlier.  OK.

Comment changed to:

                /*
                 * When the acl is not masked, there is no need to determine if
                 * the process is in the group class and we can earlier break
                 * out of the loop below.
                 */

makes sense, just replace "earlier break out" by "break out earlier".

quoted

Patch makes sense to me, ACK.

Thanks,
Andreas

--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html