Thread (5 messages) 5 messages, 2 authors, 2015-08-10

Re: [PATCH 1/4] selftests: vm: Fix mlock2-tests for 32-bit architectures

flat view

From: Shuah Khan <hidden>
Date: 2015-08-10 19:27:58
Also in: lkml

On 08/07/2015 07:44 AM, Thierry Reding wrote:
From: Thierry Reding <redacted>

According to Documentation/vm/pagemap.txt, the /proc/pid/pagemap file
contains one 64-bit value for each virtual page. The test code relies
on the size of unsigned long being 64-bit, which breaks the test when
run on 32-bit architectures. Use a uint64_t to store values read from
the file instead, so that it works irrespective of the architecture's
word size.

Signed-off-by: Thierry Reding <redacted>
---
Looks good to me. Andrew! Would you like me to take this patch
and the other two in this series through kselftest git?

thanks,
-- Shuah


-- 
Shuah Khan
Sr. Linux Kernel Developer
Open Source Innovation Group
Samsung Research America (Silicon Valley)
shuahkh-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org | (970) 217-8978
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help