[PATCH v5 33/39] ext4: Don't allow unmapped identifiers in richacls
From: Andreas Gruenbacher <hidden>
Date: 2015-07-22 13:03:23
Also in:
linux-fsdevel, linux-nfs, lkml
Subsystem:
ext4 file system, filesystems (vfs and infrastructure), the rest · Maintainers:
"Theodore Ts'o", Alexander Viro, Christian Brauner, Linus Torvalds
From: Andreas Gruenbacher <agruenba@redhat.com> Don't allow acls which contain unmapped identifiers: they are meaningful for remote file systems only. Signed-off-by: Andreas Gruenbacher <agruenba@redhat.com> --- fs/ext4/richacl.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/fs/ext4/richacl.c b/fs/ext4/richacl.c
index 6ffb2ae..8aa539e 100644
--- a/fs/ext4/richacl.c
+++ b/fs/ext4/richacl.c@@ -68,7 +68,13 @@ ext4_set_richacl(handle_t *handle, struct inode *inode, struct richacl *acl) int retval; if (acl) { - mode_t mode = inode->i_mode; + mode_t mode; + + /* Don't allow acls with unmapped identifiers. */ + if (richacl_has_unmapped_identifiers(acl)) + return -EINVAL; + + mode = inode->i_mode; if (richacl_equiv_mode(acl, &mode) == 0) { inode->i_mode = mode; ext4_mark_inode_dirty(handle, inode);
--
2.4.3