Thread (2 messages) 2 messages, 2 authors, 2015-07-10

Re: [RFCv3 3/5] mm/balloon: apply mobile page migratable into balloon

From: Gioh Kim <hidden>
Date: 2015-07-10 00:21:40
Also in: linux-fsdevel, linux-mm, lkml, virtualization

Possibly related (same subject, not in this thread)

quoted
@@ -124,6 +130,7 @@ static inline void balloon_page_insert(struct balloon_dev_info *balloon,
  				       struct page *page)
  {
  	__SetPageBalloon(page);
+	page->mapping = balloon->inode->i_mapping;
  	SetPagePrivate(page);
  	set_page_private(page, (unsigned long)balloon);
  	list_add(&page->lru, &balloon->pages);
@@ -140,6 +147,7 @@ static inline void balloon_page_insert(struct balloon_dev_info *balloon,
  static inline void balloon_page_delete(struct page *page)
  {
  	__ClearPageBalloon(page);
+	page->mapping = NULL;
  	set_page_private(page, 0);
  	if (PagePrivate(page)) {
  		ClearPagePrivate(page);
Order of cleanup here is not the reverse of the order of initialization.
Better make it exactly the reverse.


Also, I have a question: is it enough to lock the page to make changing
the mapping safe? Do all users lock the page too?


I think balloon developers can answer that precisely.

I've just follow this comment:
http://lxr.free-electrons.com/source/include/linux/balloon_compaction.h#L16
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help