Thread (57 messages) 57 messages, 7 authors, 2015-07-31

Re: [PATCH -mm v9 0/8] idle memory tracking

flat view

From: Vladimir Davydov <hidden>
Date: 2015-07-31 09:35:19
Also in: cgroups, linux-mm, lkml

On Thu, Jul 30, 2015 at 04:01:22PM +0300, Vladimir Davydov wrote:
On Thu, Jul 30, 2015 at 12:12:12PM +0300, Vladimir Davydov wrote:
quoted
On Wed, Jul 29, 2015 at 02:30:15PM -0700, Andrew Morton wrote:
quoted
On Wed, 29 Jul 2015 19:29:08 +0300 Vladimir Davydov [off-list ref] wrote:
quoted
/proc/kpageidle should probably live somewhere in /sys/kernel/mm, but I
added it where similar files are located (kpagecount, kpageflags) to
keep things consistent.
I think these files should be moved elsewhere.  Consistency is good,
but not when we're being consistent with a bad thing.

So let's place these in /sys/kernel/mm and then start being consistent
with that?
I really don't think we should separate kpagecgroup from kpagecount and
kpageflags, because they look very similar (each of them is read-only,
contains an array of u64 values referenced by PFN). Scattering these
files between different filesystems would look ugly IMO.

However, kpageidle is somewhat different (it's read-write, contains a
bitmap) so I think it's worth moving it to /sys/kernel/mm. We have to
move the code from fs/proc to mm/something then to remove dependency
from PROC_FS, which would be unnecessary. Let me give it a try.
Here it goes:

From: Vladimir Davydov <redacted>
Subject: [PATCH] Move /proc/kpageidle to /sys/kernel/mm/page_idle/bitmap
Since it is rather difficult to merge it into proc-add-kpageidle, should
I resend the whole series with all fixes included, provided you find
this patch OK of course?

Thanks,
Vladimir
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help