Thread (4 messages) flat view 4 messages, 4 authors, 2015-07-31

Re: [PATCH] kdbus/samples: skip on CROSS_COMPILE

From: Greg Kroah-Hartman <hidden>
Date: 2015-07-30 16:33:10
Also in: lkml

On Thu, Jul 30, 2015 at 06:13:25PM +0200, David Herrmann wrote:
quoted hunk
Apparently we cannot rely on up-to-date kernel headers to be available
when cross-compiling, not even for HOSTCC. That's sad, but it's how it
is. Skip samples on cross-compiles as suggested by Paul, so allmodconfig
runs smoothly again.

Tested-by: Paul Gortmaker <redacted>
Signed-off-by: David Herrmann <redacted>
---
 samples/kdbus/Makefile | 4 ++++
 1 file changed, 4 insertions(+)
diff --git a/samples/kdbus/Makefile b/samples/kdbus/Makefile
index 137f842..dbd9de8 100644
--- a/samples/kdbus/Makefile
+++ b/samples/kdbus/Makefile
@@ -1,9 +1,13 @@
 # kbuild trick to avoid linker error. Can be omitted if a module is built.
 obj- := dummy.o
 
+ifndef CROSS_COMPILE
This really feels like the wrong solution.
+
 hostprogs-$(CONFIG_SAMPLE_KDBUS) += kdbus-workers
 
 always := $(hostprogs-y)
 
 HOSTCFLAGS_kdbus-workers.o += -I$(objtree)/usr/include
 HOSTLOADLIBES_kdbus-workers := -lrt
+
+endif
Shuah, how should we fix this "properly"?  How is this resolved for the
kernel test scripts, it should have the same issue that the samples do.

thanks,

greg k-h
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help