Re: [linux-4.2-rc3/tools/testing/selftests/futex/functional/futex_requeue_pi_signal_restart.c:194: bad if condition ?

Hi!

quoted

[linux-4.2-rc3/tools/testing/selftests/futex/functional/futex_requeue_pi_signal_restart.c:194]: (style) Expression is always false because 'else if' condition matches previous condition at line 191.

Source code is

        if (res> 0) {
            atomic_set(&requeued, 1);
            break;
        } else if (res> 0) {

Hi Daren,

Is this something that could be fixed?

Looks like a typo to me. My guess is that it should have been:

...
} else if (res < 0) {
...

-- 
Cyril Hrubis
chrubis-AlSwsSmVLrQ@public.gmane.org