Thread (43 messages) flat view 43 messages, 5 authors, 2015-06-11

Re: [PATCH v5 12/21] libnvdimm: namespace indices: read and validate

From: Dan Williams <hidden>
Date: 2015-06-10 15:54:48
Also in: linux-acpi, lkml, nvdimm

On Mon, Jun 8, 2015 at 11:39 PM, Christoph Hellwig [off-list ref] wrote:
quoted
+#include <asm-generic/io-64-nonatomic-lo-hi.h>
+
+#ifndef __io_virt
+#define __io_virt(x) ((void __force *) (x))
+#endif
NAK. driver code mus never include asm-generic headers directly,
and __io_virt isn't something that's up to a driver to redefine either.

I think we really need the memremap series in first before trying to
do the things done in this patch.
I was abusing read[wlq] and write[wlq].  All this patch needs is a
conversion to use __leXXto_cpu and __cpu_to_leXX helpers.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help