Re: [PATCH 07/18] media controller: rename the tuner entity
From: Hans Verkuil <hidden>
Date: 2015-05-08 13:21:56
Also in:
linux-media
On 05/08/2015 02:57 PM, Mauro Carvalho Chehab wrote:
Em Fri, 08 May 2015 14:13:22 +0200 Hans Verkuil [off-list ref] escreveu:quoted
On 05/08/2015 03:12 AM, Mauro Carvalho Chehab wrote:quoted
Finally, let's rename the tuner entity. inside the media subsystem, a tuner can be used by AM/FM radio, SDR radio, analog TV and digital TV. It could even be used on other subsystems, like network, for wireless devices. So, it is not constricted to V4L2 API, or to a subdev. Let's then rename it as: MEDIA_ENT_T_V4L2_SUBDEV_TUNER -> MEDIA_ENT_T_TUNERSee patch 04/18.Mapping the tuner as a V4L2_SUBDEV is plain wrong. We can't assume that a tuner will always be mapped via V4L2 subdev API.
True. Today we have subdevs that have no device node to control them, so in that case it would just be a SUBDEV entity. There are subdevs that make a v4l-subdev device node, so those can be V4L(2)_SUBDEV entities. The question is: what are your ideas for e.g. DVB-only tuners? Would they get a DVB-like device node? (so DTV_SUBDEV) Would hybrid tuners have two device nodes? One v4l-subdev, one dvb/dtv-subdev? Just curious what your thoughts are. Brainstorming: It might be better to map each device node to an entity and each hardware component (tuner, DMA engine) to an entity, and avoid this mixing of hw entity vs device node entity. Hmm, we need a another brainstorm meeting... Regards, Hans