Re: [PATCH v2] Documentation/arch: Add kernel feature descriptions and arch support status under Documentation/features/

From
Ingo Molnar <hidden>
Date
2015-05-18 08:54:37
Also in
linux-arch, lkml
Reply to
Michael Ellerman, 2015-05-18
* Michael Ellerman [off-list ref] wrote:
quoted
quoted
Yes it is. I have my own version I've cobbled together for 
powerpc, but this is much better.
Please double check the PowerPC support matrix for correctness (if 
you haven't yet):
It looks good except for:
quoted
       rwsem-optimized:  |  ok  |                              Optimized asm/rwsem.h #  arch provides optimized rwsem APIs
I don't see an rwsem.h in powerpc anywhere?
Indeed, that slipped through. I fixed it to:

    triton:~/tip> cat Documentation/features/locking/rwsem-optimized/arch-support.txt 
    #
    # Feature name:          rwsem-optimized
    #         Kconfig:       Optimized asm/rwsem.h
    #         description:   arch provides optimized rwsem APIs
    #
        -----------------------
        |         arch |status|
        -----------------------
        |       alpha: |  ok  |
        |         arc: | TODO |
        |         arm: | TODO |
        |       arm64: | TODO |
        |       avr32: | TODO |
        |    blackfin: | TODO |
        |         c6x: | TODO |
        |        cris: | TODO |
        |         frv: | TODO |
        |     hexagon: | TODO |
        |        ia64: |  ok  |
        |        m32r: | TODO |
        |        m68k: | TODO |
        |       metag: | TODO |
        |  microblaze: | TODO |
        |        mips: | TODO |
        |     mn10300: | TODO |
        |       nios2: | TODO |
        |    openrisc: | TODO |
        |      parisc: | TODO |
        |     powerpc: | TODO |
        |        s390: |  ok  |
        |       score: | TODO |
        |          sh: |  ok  |
        |       sparc: |  ok  |
        |        tile: | TODO |
        |          um: | TODO |
        |   unicore32: | TODO |
        |         x86: |  ok  |
        |      xtensa: |  ok  |
        -----------------------
And this is correct but a bit confusing:
quoted
         irq-time-acct:  |  ok  |                           HAVE_IRQ_TIME_ACCOUNTING #  arch supports precise IRQ time accounting
I think you and Paul agreed it's "ok" on powerpc because we have
VIRT_CPU_ACCOUNTING instead, but that's not obvious.
Ok, so I modified it to print '..' instead:

    triton:~/tip> cat Documentation/features/time/irq-time-acct/arch-support.txt
    #
    # Feature name:          irq-time-acct
    #         Kconfig:       HAVE_IRQ_TIME_ACCOUNTING
    #         description:   arch supports precise IRQ time accounting
    #
        -----------------------
        |         arch |status|
        -----------------------
        |       alpha: |  ..  |
        |         arc: | TODO |
        |         arm: |  ok  |
        |       arm64: |  ..  |
        |       avr32: | TODO |
        |    blackfin: | TODO |
        |         c6x: | TODO |
        |        cris: | TODO |
        |         frv: | TODO |
        |     hexagon: | TODO |
        |        ia64: |  ..  |
        |        m32r: | TODO |
        |        m68k: | TODO |
        |       metag: | TODO |
        |  microblaze: | TODO |
        |        mips: |  ok  |
        |     mn10300: | TODO |
        |       nios2: | TODO |
        |    openrisc: | TODO |
        |      parisc: |  ..  |
        |     powerpc: |  ..  |
        |        s390: |  ..  |
        |       score: | TODO |
        |          sh: | TODO |
        |       sparc: |  ..  |
        |        tile: |  ..  |
        |          um: | TODO |
        |   unicore32: | TODO |
        |         x86: |  ok  |
        |      xtensa: |  ok  |
        -----------------------

i.e. it's not marked as TODO, but not as supported either which would 
be misleading.

Thanks,

	Ingo
Thread (46 messages) 46 messages, 13 authors, last reply 2015-06-08
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help