Re: [RFC 1/4] fs: Add generic file system event notifications

On Fri 17-04-15 15:04:37, Beata Michalska wrote:

On 04/17/2015 01:31 PM, Jan Kara wrote:

quoted

On Wed 15-04-15 09:15:44, Beata Michalska wrote:
Also I think that we should make it clear that each event type has
different set of arguments. For threshold events they'll be L1 & L2, for
other events there may be no arguments, for other events maybe something
else...

Currently only the threshold events use arguments -  not sure what arguments
could be used for the remaining notifications. But any suggestions are welcomed.

  Me neither be someone will surely find something in future ;)

quoted

...

quoted

+static const match_table_t fs_etypes = {
+	{ FS_EVENT_INFO,    "info"  },
+	{ FS_EVENT_WARN,    "warn"  },
+	{ FS_EVENT_THRESH,  "thr"   },
+	{ FS_EVENT_ERR,     "err"   },
+	{ 0, NULL },
+};

  Why are there these generic message types? Threshold messages make good
sense to me. But not so much the rest. If they don't have a clear meaning,
it will be a mess. So I also agree with a message like - "filesystem has
trouble, you should probably unmount and run fsck" - that's fine. But
generic "info" or "warning" doesn't really carry any meaning on its own and
thus seems pretty useless to me. To explain a bit more, AFAIU this
shouldn't be a generic logging interface where something like severity
makes sense but rather a relatively specific interface notifying about
events in filesystem userspace should know about so I expect relatively low
number of types of events, not tens or even hundreds...

Getting rid of those would simplify the configuration part, indeed.
So we would be left with 'generic' and threshold events.
I guess I've overdone this part.

  Well, I would avoid defining anything that's not really used. So
currently you can define threshold events and we start with just those.
When someone hooks up filesystem error paths to send notification, we can
create event type for telling "filesystem corrupted". And so on... We just
have to be careful to document that new event types can be added and
userspace has to ignore events it does not understand.

								Honza
-- 
Jan Kara [off-list ref]
SUSE Labs, CR