Thread (1 message) 1 message, 1 author, 2015-04-12

Re: [v12 1/5] vfs: adds general codes to enforces project quota limits

From: Alban Crequy <hidden>
Date: 2015-04-12 13:49:11
Also in: linux-ext4, linux-fsdevel

On 9 April 2015 at 17:14, Li Xi [off-list ref] wrote:
quoted hunk
This patch adds support for a new quota type PRJQUOTA for project quota
enforcement. Also a new method get_projid() is added into dquot_operations
structure.
(...)
diff --git a/fs/quota/quota.c b/fs/quota/quota.c
index 2aa4151..33b30b1 100644
--- a/fs/quota/quota.c
+++ b/fs/quota/quota.c
@@ -30,7 +30,10 @@ static int check_quotactl_permission(struct super_block *sb, int type, int cmd,
        case Q_XGETQSTATV:
        case Q_XQUOTASYNC:
                break;
-       /* allow to query information for dquots we "own" */
+       /*
+        * allow to query information for dquots we "own"
+        * always allow querying project quota
+        */
I would add a precision in the comment:

always allow querying project quota when the project id is mapped in
the current user namespace.

id is the id in the current user namespace. So quotas for unmapped
users, unmapped groups or unmapped projects cannot be queried.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help