Re: [PATCH v3 1/6] virtio_balloon: transitional interface

On Wed, Apr 01, 2015 at 01:52:44PM +0200, Cornelia Huck wrote:

On Wed, 1 Apr 2015 12:49:02 +0200
"Michael S. Tsirkin" [off-list ref] wrote:

quoted

On Wed, Apr 01, 2015 at 12:35:45PM +0200, Michael S. Tsirkin wrote:

quoted

Virtio 1.0 doesn't include a modern balloon device.
But it's not a big change to support a transitional
balloon device: this has the advantage of supporting
existing drivers, transparently.

Signed-off-by: Michael S. Tsirkin <redacted>
---
 include/uapi/linux/virtio_balloon.h | 11 ++++++++--
 drivers/virtio/virtio_balloon.c     | 43 +++++++++++++++++++++++++++++--------
 2 files changed, 43 insertions(+), 11 deletions(-)

So all in all 32 LOC added, and 9 out of these
deal with endian-ness differences.

Seems like a small cost for guests to pay for a clean spec, no?

I'm not opposed to this per se, but I'm not totally convinced of the
usefulness :)

Seeing the qemu side would be helpful.

Cleaning this up for submission, should be ready RSN.

-- 
MST