Re: [Intel-gfx] [PATCH] drm/i915: fix definition of the DRM_IOCTL_I915_GET_SPRITE_COLORKEY ioctl
From: Daniel Vetter <hidden>
Date: 2015-03-27 08:04:28
Also in:
dri-devel, intel-gfx
On Fri, Mar 27, 2015 at 08:39:56AM +0200, Jani Nikula wrote:
On Thu, 26 Mar 2015, Tommi Rantala [off-list ref] wrote:quoted
Fix definition of the DRM_IOCTL_I915_GET_SPRITE_COLORKEY ioctl, so that it is different from the DRM_IOCTL_I915_SET_SPRITE_COLORKEY ioctl. Signed-off-by: Tommi Rantala <redacted>Whoa. Broken since its introduction in commit 8ea30864229e54b01ac0e9fe88c4b733a940ec4e Author: Jesse Barnes [off-list ref] Date: Tue Jan 3 08:05:39 2012 -0800 drm/i915: add color key support v4 Cc: stable-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Nope, we'll just rip it out and replace it all with the drm_noop ioctl. At least I didn't find any userspace anywhere and only broken definitions. Proof enough this isn't useful. Even more so since that means we don't have to convert the get ioctl over to atomic, yay! I'll send patches. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch