Re: [PATCH v3] Add virtio-input driver.

From
Gerd Hoffmann <hidden>
Date
2015-03-24 10:26:56
Also in
lkml
Reply to
Gerd Hoffmann, 2015-03-24
  Hi,
quoted hunk ↗ jump to hunk
+static void virtinput_cfg_abs(struct virtio_input *vi, int abs)
+{
+	u32 mi, ma, re, fu, fl;
+
+	virtinput_cfg_select(vi, VIRTIO_INPUT_CFG_ABS_INFO, abs);
+	virtio_cread(vi->vdev, struct virtio_input_config, u.abs.min, &mi);
+	virtio_cread(vi->vdev, struct virtio_input_config, u.abs.max, &ma);
+	virtio_cread(vi->vdev, struct virtio_input_config, u.abs.res, &re);
+	virtio_cread(vi->vdev, struct virtio_input_config, u.abs.fuzz, &fu);
+	virtio_cread(vi->vdev, struct virtio_input_config, u.abs.flat, &fl);
+	input_set_abs_params(vi->idev, abs, mi, ma, fu, fl);
+	input_abs_set_res(vi->idev, abs, re);
+}
quoted hunk ↗ jump to hunk
+struct virtio_input_absinfo {
+	__virtio32  min;
+	__virtio32  max;
+	__virtio32  fuzz;
+	__virtio32  flat;
+	__virtio32  res;
+};
Damn, had sparse disabled for the test builds.  [ Too bad there are way
too many warnings on a full kernel build so having sparse enabled all
the time doesn't fly. ]

So this doesn't work either.

Hmm, back to using "u32" in the virtio config structs?

cheers,
  Gerd
Thread (15 messages) 15 messages, 3 authors, last reply 2015-03-25
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help