Re: [PATCH v0 01/11] stm class: Introduce an abstraction for System Trace Module devices

Mathieu Poirier [off-list ref] writes:

As promised I worked on a prototype that connects the coresight-stm
driver with the generic STM interface you have suggested.  Things work
quite well and aside from the enhancement related to the ioctl() and
private member as discussed above, we should move ahead with this.

I will send out a new version of the coresight-stm driver as soon as I
see your patches with those changes.

Actually, instread of a private member I'd simply pass struct stm_data
pointer to the callback (like we do with other callbacks) and the
private data would be in the structure that embeds this struct stm_data,
so that you can get to it using container_of():

struct my_stm {
       struct stm_data	data;
       void		*my_stuff;
       ...
};

...

long my_ioctl(struct stm_data *data, unsigned int cmd, unsigned long
	      arg)
{
        struct my_stm *mine = container_of(data, struct my_stm, data);

...

Would this work for you? I'm otherwise ready to send the second version
of my patchset.

Regards,
--
Alex