Re: [PATCH v4 4/9] selftests: Add install target

On Mon, 2015-03-16 at 14:04 +1100, Michael Ellerman wrote:

On Fri, 2015-03-13 at 15:32 -0600, Shuah Khan wrote:

quoted

On 03/13/2015 11:20 AM, Shuah Khan wrote:

quoted

On 03/10/2015 10:06 PM, Michael Ellerman wrote:

quoted

This adds make install support to selftests. The basic usage is:

$ cd tools/testing/selftests
$ make install

That installs into tools/testing/selftests/install, which can then be
copied where ever necessary.

The install destination is also configurable using eg:

$ INSTALL_PATH=/mnt/selftests make install

The implementation uses two targets in the child makefiles. The first
"install" is expected to install all files into $(INSTALL_PATH).

The second, "emit_tests", is expected to emit the test instructions (ie.
bash script) on stdout. Separating this from install means the child
makefiles need no knowledge of the location of the test script.

Signed-off-by: Michael Ellerman <mpe-Gsx/Oe8HsFggBc27wqDAHg@public.gmane.org>

Thanks for doing the work. This patch will be applied to next and will
be queued for 4.1

ok. linux-kselftest next has both shared logic and install patches
now.

Thanks, looks good to me.

And also 6/9 "selftests: Set CC using CROSS_COMPILE once in lib.mk" would be
nice and is uncontroversial, I think:

https://lkml.org/lkml/2015/3/11/5

cheers