Re: [PATCH 43/45] include/uapi/linux/netfilter_bridge.h: include if.h

On Tue, Feb 17, 2015 at 01:02:50AM +0100, Jan Engelhardt wrote:

On Tuesday 2015-02-17 00:05, Mikko Rapeli wrote:

quoted

Fixes userspace compilation errors like:

error: field ‘in’ has incomplete type
struct in_addr in;

+#include <linux/if.h>

Patch 36/45 included linux/in.h instead of linux/if.h for addressing "in has incomplete
type". Should this be used here too?

It could, yes. It seems I cut some corners since this was hiding behind it:

In file included from ./linux/netfilter_bridge.h:11:0,
                 from ./linux/netfilter_bridge.c:1:
./linux/if_pppox.h:42:11: error: ‘IFNAMSIZ’ undeclared here (not in a function)
  char          dev[IFNAMSIZ];          /* Local device to use */

I'll fix these.

-Mikko