On Tue, Feb 17, 2015 at 12:47:58AM +0900, Namjae Jeon wrote:

quoted

From: Namjae Jeon <redacted>

This commit adds fallocate FALLOC_FL_INSERT_RANGE support for fsx.

Signed-off-by: Namjae Jeon <redacted>
Signed-off-by: Ashish Sangwan <redacted>
Reviewed-by: Brian Foster <redacted>
---
 ltp/fsx.c |  124 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++-----
 1 file changed, 114 insertions(+), 10 deletions(-)

.....

quoted

@@ -339,6 +341,14 @@ logdump(void)
 						     lp->args[0] + lp->args[1])
 				prt("\t******CCCC");
 			break;
+		case OP_INSERT_RANGE:
+			prt("INSERT 0x%x thru 0x%x\t(0x%x bytes)",
+			    lp->args[0], lp->args[0] + lp->args[1] - 1,
+			    lp->args[1]);
+			if (badoff >= lp->args[0] && badoff <
+						     lp->args[0] + lp->args[1])
+				prt("\t******CCCC");

Hi Dave,

Probably should output "*****IIII" so we can distinguish it from
collapse operations easily.

Right. I will change it.

quoted

@@ -1307,6 +1403,9 @@ usage(void)
 #ifdef FALLOC_FL_COLLAPSE_RANGE
 "	-C: Do not use collapse range calls\n"
 #endif
+#ifdef FALLOC_FL_INSERT_RANGE
+"	-i: Do not use insert range calls\n"
+#endif

I'd make that "-I" rather than "-i" so it matches with the "-C" of
collapse range.

Okay.

Thanks for your review!

Cheers,

Dave.
--
Dave Chinner
david@fromorbit.com