Re: [PATCH v12 1/2] crypto: AF_ALG: add AEAD support

On 02/27/2015 02:26 AM, Stephan Mueller wrote:

quoted

quoted

quoted

This patch adds the AEAD support for AF_ALG.

quoted

quoted

quoted

The implementation is based on algif_skcipher, but contains heavy
modifications to streamline the interface for AEAD uses.

To use AEAD, the user space consumer has to use the salg_type named
"aead".

I just saw Al Viro's patch to use the iov_iter API in
algif_skcipher.c. I looked at it but lacked documentation for using
it properly. Now I have a template that I will incorporate into
algif_aead.c

Please resubmit once you have done this.

I have done that, but as indicated with an email to Al, I cannot get his 
patch for skcipher and hash to work. Similarly, my modification for the 
AEAD does not work either. So, I do not see that Al's patch can be 
merged as is.

Therefore, I have not submitted my patch as Al mentioned he wanted to 
look into his patchset.

Hi Stephan,
There was a problem with the iov_iter changes, but it has been fixed on netdev during merging window.
The algif_skcipher works fine for me on the latest (4.0.0-rc1+) cryptodev.

Regards,
Tadeusz