Re: [PATCH v2 02/18] ARM: ARMv7M: Enlarge vector table to 256 entries

Started by Uwe Kleine-König on Feb 20, 2015 · 4 messages from 2 authors · Last reply Feb 26, 2015

open the first message on its own page

Uwe Kleine-König

Message details and related content
Open message details and related content
On Fri, Feb 20, 2015 at 07:01:01PM +0100, Maxime Coquelin wrote:
quoted hunk
From Cortex-M reference manuals, the nvic supports up to 240 interrupts.
So the number of entries in vectors table is up to 256.

This patch adds a new config flag to specify the number of external interrupts.
Some ifdeferies are added in order to respect the natural alignment without
wasting too much space on smaller systems.

Signed-off-by: Maxime Coquelin <mcoquelin.stm32@gmail.com>
---
 arch/arm/kernel/entry-v7m.S | 13 +++++++++----
 arch/arm/mm/Kconfig         | 15 +++++++++++++++
 2 files changed, 24 insertions(+), 4 deletions(-)

diff --git a/arch/arm/kernel/entry-v7m.S b/arch/arm/kernel/entry-v7m.S
index 8944f49..68cde36 100644
--- a/arch/arm/kernel/entry-v7m.S
+++ b/arch/arm/kernel/entry-v7m.S
@@ -117,9 +117,14 @@ ENTRY(__switch_to)
 ENDPROC(__switch_to)
 
 	.data
-	.align	8
+#if CONFIG_CPUV7M_NUM_IRQ <= 112
I would have called this CONFIG_CPU_V7M_NUM_IRQ to match the already
existing CPU_V7M symbol.
quoted hunk
+	.align	9
+#else
+	.align	10
+#endif
+
Other than that:
Acked-by: Uwe Kleine-König <redacted>

Who do you target to apply this series?

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

Maxime Coquelin replied to Uwe Kleine-König

Message details and related content
Open message details and related content
2015-02-20 20:47 GMT+01:00 Uwe Kleine-König [off-list ref]:
On Fri, Feb 20, 2015 at 07:01:01PM +0100, Maxime Coquelin wrote:
quoted
From Cortex-M reference manuals, the nvic supports up to 240 interrupts.
So the number of entries in vectors table is up to 256.

This patch adds a new config flag to specify the number of external interrupts.
Some ifdeferies are added in order to respect the natural alignment without
wasting too much space on smaller systems.

Signed-off-by: Maxime Coquelin <mcoquelin.stm32@gmail.com>
---
 arch/arm/kernel/entry-v7m.S | 13 +++++++++----
 arch/arm/mm/Kconfig         | 15 +++++++++++++++
 2 files changed, 24 insertions(+), 4 deletions(-)

diff --git a/arch/arm/kernel/entry-v7m.S b/arch/arm/kernel/entry-v7m.S
index 8944f49..68cde36 100644
--- a/arch/arm/kernel/entry-v7m.S
+++ b/arch/arm/kernel/entry-v7m.S
@@ -117,9 +117,14 @@ ENTRY(__switch_to)
 ENDPROC(__switch_to)

      .data
-     .align  8
+#if CONFIG_CPUV7M_NUM_IRQ <= 112
I would have called this CONFIG_CPU_V7M_NUM_IRQ to match the already
existing CPU_V7M symbol.
That's better indeed.
It will be changed in v3.

quoted
+     .align  9
+#else
+     .align  10
+#endif
+
Other than that:
Acked-by: Uwe Kleine-König <redacted>

Who do you target to apply this series?
I guess it should go through Russell's Patch Tracking System?

Thanks,
Maxime
Best regards
Uwe

--
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |





  

    

      
      Maxime Coquelin      replied to Maxime Coquelin      
      
    

  

  

    Message details and related content
    
Open message details and related content

  

  
2015-02-23 11:33 GMT+01:00 Maxime Coquelin [off-list ref]:
2015-02-20 20:47 GMT+01:00 Uwe Kleine-König [off-list ref]:
quoted
On Fri, Feb 20, 2015 at 07:01:01PM +0100, Maxime Coquelin wrote:
quoted
From Cortex-M reference manuals, the nvic supports up to 240 interrupts.
So the number of entries in vectors table is up to 256.

This patch adds a new config flag to specify the number of external interrupts.
Some ifdeferies are added in order to respect the natural alignment without
wasting too much space on smaller systems.

Signed-off-by: Maxime Coquelin <mcoquelin.stm32@gmail.com>
---
 arch/arm/kernel/entry-v7m.S | 13 +++++++++----
 arch/arm/mm/Kconfig         | 15 +++++++++++++++
 2 files changed, 24 insertions(+), 4 deletions(-)

diff --git a/arch/arm/kernel/entry-v7m.S b/arch/arm/kernel/entry-v7m.S
index 8944f49..68cde36 100644
--- a/arch/arm/kernel/entry-v7m.S
+++ b/arch/arm/kernel/entry-v7m.S
@@ -117,9 +117,14 @@ ENTRY(__switch_to)
 ENDPROC(__switch_to)

      .data
-     .align  8
+#if CONFIG_CPUV7M_NUM_IRQ <= 112
I would have called this CONFIG_CPU_V7M_NUM_IRQ to match the already
existing CPU_V7M symbol.
That's better indeed.
It will be changed in v3.

quoted
quoted
+     .align  9
+#else
+     .align  10
+#endif
+
Other than that:
Acked-by: Uwe Kleine-König <redacted>
4 more quoted lines
Sorry, I answered your question too quickly.
I meant this patch should go through Russell's Patch Tracking System.

For the other patches, I think it should be picked by their respective
maintainers.
Or I can create an immutable tag (on github or kernel.org?) that will
be merged by the different sub-systems?
What would you advise?

Thanks,
Maxime

Thanks,
Maxime
quoted
Best regards
Uwe

--
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |





  

    

      
      Uwe Kleine-König      replied to Maxime Coquelin      
      
    

  

  

    Message details and related content
    
Open message details and related content

  

  
On Thu, Feb 26, 2015 at 11:29:52AM +0100, Maxime Coquelin wrote:
2015-02-23 11:33 GMT+01:00 Maxime Coquelin [off-list ref]:
quoted
2015-02-20 20:47 GMT+01:00 Uwe Kleine-König [off-list ref]:
quoted
Who do you target to apply this series?
I guess it should go through Russell's Patch Tracking System?
Sorry, I answered your question too quickly.
I meant this patch should go through Russell's Patch Tracking System.

For the other patches, I think it should be picked by their respective
maintainers.
Or I can create an immutable tag (on github or kernel.org?) that will
be merged by the different sub-systems?
What would you advise?
Depends on the interdependencies of your patches. If each maintainer can
just pick up the patches affecting his area on top of (say) 4.0-rc1 that
would be good.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |






    
  

  
    

      

        Keyboard shortcuts
      

      

        
          
hback out one level

          
jnext message in thread / next series-diff position

          
kprevious message in thread / previous series-diff position

          
ldrill in

          
Escclose help / fold thread tree

          
?toggle this help