@@ -42,6 +42,10 @@#include<asm/ioctl.h>typedefunsignedintdrm_handle_t;+#ifndef __KERNEL__+#include<stdlib.h>+#endif+#else /* One of the BSDs */#include<sys/ioccom.h>
From: Emil Velikov <hidden> Date: 2015-02-23 10:26:56
On 16/02/15 23:05, Mikko Rapeli wrote:
Fixes <drm/drm.h> compilation error:
drm/drm.h:132:2: error: unknown type name ‘size_t’
Hi Mikko,
Can you let us know how you're getting these (series-wise) errors ? I've
been meaning to sync the uapi/drm and libdrm headers and would be nice
to have an extra step to test things.
Thanks
Emil
From: Mikko Rapeli <hidden> Date: 2015-02-23 10:35:54
On Mon, Feb 23, 2015 at 10:26:58AM +0000, Emil Velikov wrote:
On 16/02/15 23:05, Mikko Rapeli wrote:
quoted
Fixes <drm/drm.h> compilation error:
drm/drm.h:132:2: error: unknown type name ‘size_t’
Hi Mikko,
Can you let us know how you're getting these (series-wise) errors ? I've
been meaning to sync the uapi/drm and libdrm headers and would be nice
to have an extra step to test things.
This should have everything needed to reproduce these compile errors,
though some of the errors hide behind other errors and fixes:
https://lkml.org/lkml/2015/2/16/525
-Mikko
From: Emil Velikov <hidden> Date: 2015-03-20 20:25:44
On 23 February 2015 at 10:35, Mikko Rapeli [off-list ref] wrote:
On Mon, Feb 23, 2015 at 10:26:58AM +0000, Emil Velikov wrote:
quoted
On 16/02/15 23:05, Mikko Rapeli wrote:
quoted
Fixes <drm/drm.h> compilation error:
drm/drm.h:132:2: error: unknown type name ‘size_t’
Hi Mikko,
Can you let us know how you're getting these (series-wise) errors ? I've
been meaning to sync the uapi/drm and libdrm headers and would be nice
to have an extra step to test things.
This should have everything needed to reproduce these compile errors,
though some of the errors hide behind other errors and fixes:
https://lkml.org/lkml/2015/2/16/525
Thanks for the link Mikko.
Afaict the general consensus seems to be that one should avoid using
stdint's uint8_t, but stick to __u8 and friends. Did you had the
chance to roll out another series that does so ?
That aside I'm not 100% sure that doing the UAPI split, as is, was the
perfect solution. Afaik drm used to live as an out of tree userspace
library(libdrm). Not sure at which point the major restructuring took
part, but one is certain - libdrm remains the only authoritative
sources of the headers. It's possible that some buggy programs pull
the UAPI headers while linking against the library, but I'd say that
won't end up well in the long term. Additionally since the UAPI split
the `make update-headers' target used to sync libdrm's headers have
been broken leading people to copy misc. hunks and/or files. Leading
to greater chance of things going sour.
All that said, I will need to gather some opinions for drm developers
and maintainers if the idea of part revering 718dcedd7e8(UAPI:
(Scripted) Disintegrate include/drm) will be the way forward.
Thanks
Emil
From: Mikko Rapeli <hidden> Date: 2015-03-21 12:17:20
On Fri, Mar 20, 2015 at 08:25:40PM +0000, Emil Velikov wrote:
On 23 February 2015 at 10:35, Mikko Rapeli [off-list ref] wrote:
quoted
On Mon, Feb 23, 2015 at 10:26:58AM +0000, Emil Velikov wrote:
quoted
On 16/02/15 23:05, Mikko Rapeli wrote:
quoted
Fixes <drm/drm.h> compilation error:
drm/drm.h:132:2: error: unknown type name ‘size_t’
Hi Mikko,
Can you let us know how you're getting these (series-wise) errors ? I've
been meaning to sync the uapi/drm and libdrm headers and would be nice
to have an extra step to test things.
This should have everything needed to reproduce these compile errors,
though some of the errors hide behind other errors and fixes:
https://lkml.org/lkml/2015/2/16/525
Thanks for the link Mikko.
Afaict the general consensus seems to be that one should avoid using
stdint's uint8_t, but stick to __u8 and friends. Did you had the
chance to roll out another series that does so ?
Yes, new series with these changes is on the way. I'm trying to follow up to
all other review comments as well and get down to 100% compiling uapi
headers; 35 failures to go...
That aside I'm not 100% sure that doing the UAPI split, as is, was the
perfect solution. Afaik drm used to live as an out of tree userspace
library(libdrm). Not sure at which point the major restructuring took
part, but one is certain - libdrm remains the only authoritative
sources of the headers. It's possible that some buggy programs pull
the UAPI headers while linking against the library, but I'd say that
won't end up well in the long term. Additionally since the UAPI split
the `make update-headers' target used to sync libdrm's headers have
been broken leading people to copy misc. hunks and/or files. Leading
to greater chance of things going sour.
All that said, I will need to gather some opinions for drm developers
and maintainers if the idea of part revering 718dcedd7e8(UAPI:
(Scripted) Disintegrate include/drm) will be the way forward.
Ok, I'll follow what is available in Linus' tree (or -next, not shure which
one I should track for these changes).
-Mikko
From: Emil Velikov <hidden> Date: 2015-04-09 16:00:55
Hi Mikko
Pardon for the late response,
On 21 March 2015 at 12:17, Mikko Rapeli [off-list ref] wrote:
On Fri, Mar 20, 2015 at 08:25:40PM +0000, Emil Velikov wrote:
quoted
On 23 February 2015 at 10:35, Mikko Rapeli [off-list ref] wrote:
quoted
On Mon, Feb 23, 2015 at 10:26:58AM +0000, Emil Velikov wrote:
quoted
On 16/02/15 23:05, Mikko Rapeli wrote:
quoted
Fixes <drm/drm.h> compilation error:
drm/drm.h:132:2: error: unknown type name ‘size_t’
Hi Mikko,
Can you let us know how you're getting these (series-wise) errors ? I've
been meaning to sync the uapi/drm and libdrm headers and would be nice
to have an extra step to test things.
This should have everything needed to reproduce these compile errors,
though some of the errors hide behind other errors and fixes:
https://lkml.org/lkml/2015/2/16/525
Thanks for the link Mikko.
Afaict the general consensus seems to be that one should avoid using
stdint's uint8_t, but stick to __u8 and friends. Did you had the
chance to roll out another series that does so ?
Yes, new series with these changes is on the way. I'm trying to follow up to
all other review comments as well and get down to 100% compiling uapi
headers; 35 failures to go...
Glad to hear that it's getting there. Might be a bit slower than
expected but we'll get there :-) Can you please Cc me on the next
iteration ?
quoted
That aside I'm not 100% sure that doing the UAPI split, as is, was the
perfect solution. Afaik drm used to live as an out of tree userspace
library(libdrm). Not sure at which point the major restructuring took
part, but one is certain - libdrm remains the only authoritative
sources of the headers. It's possible that some buggy programs pull
the UAPI headers while linking against the library, but I'd say that
won't end up well in the long term. Additionally since the UAPI split
the `make update-headers' target used to sync libdrm's headers have
been broken leading people to copy misc. hunks and/or files. Leading
to greater chance of things going sour.
All that said, I will need to gather some opinions for drm developers
and maintainers if the idea of part revering 718dcedd7e8(UAPI:
(Scripted) Disintegrate include/drm) will be the way forward.
Ok, I'll follow what is available in Linus' tree (or -next, not shure which
one I should track for these changes).
After discussing (more like annoying) our DRM maintainer we got to the
conclusion that the headers will stay exposed to userspace. So any and
all of your work will be greatly appreciated.
Thanks
Emil
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
From: Mikko Rapeli <hidden> Date: 2015-04-09 16:09:42
On Thu, Apr 09, 2015 at 05:00:48PM +0100, Emil Velikov wrote:
Hi Mikko
Pardon for the late response,
On 21 March 2015 at 12:17, Mikko Rapeli [off-list ref] wrote:
quoted
On Fri, Mar 20, 2015 at 08:25:40PM +0000, Emil Velikov wrote:
quoted
On 23 February 2015 at 10:35, Mikko Rapeli [off-list ref] wrote:
quoted
On Mon, Feb 23, 2015 at 10:26:58AM +0000, Emil Velikov wrote:
quoted
On 16/02/15 23:05, Mikko Rapeli wrote:
quoted
Fixes <drm/drm.h> compilation error:
drm/drm.h:132:2: error: unknown type name ‘size_t’
Hi Mikko,
Can you let us know how you're getting these (series-wise) errors ? I've
been meaning to sync the uapi/drm and libdrm headers and would be nice
to have an extra step to test things.
This should have everything needed to reproduce these compile errors,
though some of the errors hide behind other errors and fixes:
https://lkml.org/lkml/2015/2/16/525
Thanks for the link Mikko.
Afaict the general consensus seems to be that one should avoid using
stdint's uint8_t, but stick to __u8 and friends. Did you had the
chance to roll out another series that does so ?
Yes, new series with these changes is on the way. I'm trying to follow up to
all other review comments as well and get down to 100% compiling uapi
headers; 35 failures to go...
Glad to hear that it's getting there. Might be a bit slower than
expected but we'll get there :-) Can you please Cc me on the next
iteration ?