Re: [Patch v4] firmware: dmi-sysfs: add SMBIOS entry point area attribute

From
Ivan Khoronzhuk <hidden>
Date
2015-02-12 02:33:38
Also in
lkml
Reply to
Matt Fleming, 2015-02-11
On 02/11/2015 04:43 PM, Matt Fleming wrote:
quoted hunk ↗ jump to hunk
On Wed, 11 Feb, at 02:17:03PM, Matt Fleming wrote:
quoted
On Tue, 10 Feb, at 11:51:44AM, Ivan Khoronzhuk wrote:
quoted
If you are Ok with this patch, could you please pickup it?
Applied, thanks Ivan!
Btw this patch doesn't apply cleanly, the reject looks like this,
--- drivers/firmware/dmi_scan.c
+++ drivers/firmware/dmi_scan.c
@@ -537,6 +543,8 @@
  		dmi_ver &= 0xFFFFFF;
The problem is in above string.
I used linux next, but I had one patch before.
Sorry... just forgot about it.
I've attached the same patch but on top of linux_next,
it can be applied cleanly.
Sorry once again and thanks!
  		dmi_len = get_unaligned_le32(buf + 12);
  		dmi_base = get_unaligned_le64(buf + 16);
+		smbios_header_size = buf[6];
+		memcpy(smbios_header, buf, smbios_header_size);
  
  		/*
  		 * The 64-bit SMBIOS 3.0 entry point no longer has a field

What version of the kernel did you base this patch on? The conflict is
trivial to fixup and I've done so and pushed it out on the EFI 'next'
branch, but I wanted to call out this conflict explicitly.
  

Attachments

Thread (9 messages) 9 messages, 4 authors, last reply 2015-03-19
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help