Re: [PATCH v17 1/7] mm: support madvise(MADV_FREE)

On Fri, Feb 06, 2015 at 01:58:25PM +0100, Michal Hocko wrote:

On Thu 05-02-15 16:33:11, Shaohua Li wrote:
[...]

quoted

Did you think about move the MADV_FREE pages to the head of inactive LRU, so
they can be reclaimed easily?

Yes this makes sense for pages living on the active LRU list. I would
preserve LRU ordering on the inactive list because there is no good
reason to make the operation more costly for inactive pages. On the
other hand having tons of to-be-freed pages on the active list clearly
sucks. Care to send a patch?

Considering anon pages are in active LRU first, it's likely MADV_FREE pages are
in active list. I'm curious why preserves the order of inactive list. App knows
which pages are cold, why don't take the advantages? I'll play the patch more
to see what I can do for it.

Thanks,
Shaohua

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>