Re: [PATCH net-next v1 01/18] net: ethtool: propagate get_settings error
From: Ben Hutchings <hidden>
Date: 2015-01-28 20:13:52
Also in:
lkml, netdev
On Mon, 2015-01-26 at 17:35 -0800, David Decotigny wrote:
quoted hunk ↗ jump to hunk
From: David Decotigny <redacted> Signed-off-by: David Decotigny <redacted> --- net/core/ethtool.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/net/core/ethtool.c b/net/core/ethtool.c index 91f74f3..52efb7e 100644 --- a/net/core/ethtool.c +++ b/net/core/ethtool.c@@ -364,7 +364,7 @@ static int ethtool_get_settings(struct net_device *dev, void __user *useraddr) if (copy_to_user(useraddr, &cmd, sizeof(cmd))) return -EFAULT; - return 0; + return err;
err cannnot be negative at this point (and if it's positive, that's a bug in the get_settings implementation which we happen to fix up). Ben.
} static int ethtool_set_settings(struct net_device *dev, void __user *useraddr)
-- Ben Hutchings Teamwork is essential - it allows you to blame someone else.
Attachments
- signature.asc [application/pgp-signature] 811 bytes