Re: [PATCH v3 00/20] kselftest install target feature
From: Michael Ellerman <hidden>
Date: 2014-12-29 05:00:49
Also in:
linux-kbuild, lkml, netdev
On Wed, 2014-12-24 at 09:27 -0700, Shuah Khan wrote:
This patch series adds a new kselftest_install make target to enable selftest install. When make kselftest_install is run, selftests are installed on the system. A new install target is added to selftests Makefile which will install targets for the tests that are specified in INSTALL_TARGETS. During install, a script is generated to run tests that are installed. This script will be installed in the selftest install directory. Individual test Makefiles are changed to add to the script. This will allow new tests to add install and run test commands to the generated kselftest script. kselftest target now depends on kselftest_install and runs the generated kselftest script to reduce duplicate work and for common look and feel when running tests. This approach leverages and extends the existing framework that uses makefile targets to implement run_tests and adds install target. This will scale well as new tests get added and makes it easier for test writers to add install target at the same time new test gets added. This v3 series reduces duplicate code to generate script in indiviual test Makefiles and consolidates support in selftests main Makefile. In the main Makefile, it does minimal work to set and export install path. In this series exec and powerpc tests are not included in the install, this work will be done in future patches. exec and powerpc are still run when make kselftest is invoked.
Any particular reason you excluded the powerpc tests? Going by a quick count, powerpc has 32 of the 54 self tests, ie. more than half. Sorry I didn't get a chance to review v1 or v2, but is this really the best solution we can come up with? It seems to involve a lot of boiler plate getting repeated in every Makefile. I'm off this week so I can't immediately come up with something better, I'll try in the new year. cheers