Thread (9 messages) flat view 9 messages, 4 authors, 2014-12-04

Re: [PATCH v5] selftest: size: Add size test for Linux kernel

From: Michael Ellerman <mpe@ellerman.id.au>
Date: 2014-12-03 03:43:15
Also in: lkml

On Tue, 2014-12-02 at 19:36 -0800, Tim Bird wrote:
This test shows the amount of memory used by the system.
Note that this is dependent on the user-space that is loaded
when this program runs.  Optimally, this program would be
run as the init program itself.
Sorry to only chime in at v5.
quoted hunk ↗ jump to hunk
diff --git a/tools/testing/selftests/size/Makefile b/tools/testing/selftests/size/Makefile
new file mode 100644
index 0000000..47f8e9c
--- /dev/null
+++ b/tools/testing/selftests/size/Makefile
@@ -0,0 +1,15 @@
+#ifndef CC
+	CC = $(CROSS_COMPILE)gcc
+#endif
I think the following is preferable:

  CC := $(CROSS_COMPILE)$(CC)


It allows optionally setting a custom CC, as well as optionally CROSS_COMPILE.

The only thing it doesn't do is choose gcc explicitly, but you shouldn't really
do that anyway - unless you absolutely require gcc. Let the user choose their
compiler by choosing where cc points.

cheers
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help