Thread (25 messages) flat view 25 messages, 6 authors, 2014-12-08

Re: [tpmdd-devel] [PATCH v8 7/8] tpm: TPM 2.0 CRB Interface

From: Stefan Berger <hidden>
Date: 2014-12-02 23:09:31
Also in: lkml

On 12/02/2014 05:31 PM, Jarkko Sakkinen wrote:

+struct acpi_tpm2 {
+	struct acpi_table_header hdr;
+	u16 platform_class;
+	u16 reserved;
+	u64 control_area_pa;
+	u32 start_method;
+} __packed;
[...]
+	}
+
+	if (buf->hdr.length != sizeof(struct acpi_tpm2)) {
This should be

if (buf->hdr.length < sizeof(struct acpi_tpm2)) {

since the ACPI TPM2 table may have a variable number of 'Platform 
Specific Parameters' beyond the 'Start Method Field'. What we don't want 
to have is less, but more is fine.

    Stefan
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help