Re: [PATCH v7 16/46] virtio_blk: v1.0 support
From: Cornelia Huck <hidden>
Date: 2014-12-01 12:40:47
Also in:
lkml
From: Cornelia Huck <hidden>
Date: 2014-12-01 12:40:47
Also in:
lkml
On Mon, 1 Dec 2014 14:34:55 +0200 "Michael S. Tsirkin" [off-list ref] wrote:
On Mon, Dec 01, 2014 at 01:02:58PM +0100, Cornelia Huck wrote:quoted
On Mon, 1 Dec 2014 13:46:45 +0200 "Michael S. Tsirkin" [off-list ref] wrote:quoted
On Mon, Dec 01, 2014 at 12:33:15PM +0100, Cornelia Huck wrote:quoted
On Mon, 1 Dec 2014 11:26:58 +0200 "Michael S. Tsirkin" [off-list ref] wrote:quoted
For some places on data path, it might be worth it to cache the correct value e.g. as part of device structure. This replaces a branch with a memory load, so the gain would have to be measured, best done separately?I think we'll want to do some measuring once the basic structure is in place anyway.What's meant by in place here?That this patchset is ready :)Also it's ready to the level where benchmarking is possible, right? I don't think you should wait until we finish polishing up commit messages.
My point is that I haven't even found time yet to test this thouroughly :(