Re: [PATCHv1 5/8] cgroup: introduce cgroup namespaces

Quoting Aditya Kali (adityakali-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org):

quoted

quoted

+void free_cgroup_ns(struct cgroup_namespace *ns)
+{
+     cgroup_put(ns->root_cgrp);
+     put_user_ns(ns->user_ns);

This is a problem on error patch in copy_cgroup_ns.  The
alloc_cgroup_ns() doesn't initialize these values, so if
you should fail in proc_alloc_inum() you'll show up here
with fandom values in ns->*.

I don't see the codepath that leads to calling free_cgroup_ns() with
uninitialized members. We don't call free_cgroup_ns() on the error
path in copy_cgroup_ns().

Hm, yeah, I'm not seeing it now, sorry.