Re: [PATCH v9 net-next 2/4] net: filter: split filter.h and expose eBPF to user space
From: Alexei Starovoitov <hidden>
Date: 2014-10-14 08:43:24
Also in:
lkml, netdev
On Tue, Oct 14, 2014 at 12:34 AM, Daniel Borkmann [off-list ref] wrote:
On 10/13/2014 11:49 PM, Alexei Starovoitov wrote:quoted
On Mon, Oct 13, 2014 at 10:21 AM, Daniel Borkmann [off-list ref] wrote:quoted
On 09/03/2014 05:46 PM, Daniel Borkmann wrote: ...quoted
Ok, given you post the remaining two RFCs later on this window as you indicate, I have no objections: Acked-by: Daniel Borkmann <redacted>Ping, Alexei, are you still sending the patch for bpf_common.h or do you want me to take care of this?It's not forgotten. I'm not sending it only because net-next is closed and it seems to be -next material.Well, the point was since it's UAPI you're modifying, that it needs to be shipped before it first gets exposed to user land ... I think that should be reason enough ... there's no point in doing this at a later point in time.
Moving common #defines from filter.h into bpf_common.h can be done at any point in time. For the sake of argument if there is an app that includes both filter.h and bpf.h, it will continue to work just fine. Anyway, since you insist, I will send it now, though it definitely can wait.