Re: [PATCH v3 3/5] selftests/ipc: change test to use ksft framework

On Fri, 2014-10-03 at 13:42 -0600, Shuah Khan wrote:

On 10/03/2014 11:39 AM, Davidlohr Bueso wrote:

quoted

On Fri, 2014-10-03 at 09:36 -0600, Shuah Khan wrote:

quoted

 	msgque.key = ftok(argv[0], 822155650);
 	if (msgque.key == -1) {
-		printf("Can't make key\n");
-		return -errno;
+		printf("Can't make key: %d\n", -errno);

So printing a numeric value is quite useless when users actually run
into these errors -- which is why I like err() so much. How about using
strerror() instead?

Yes. using perror() does give better information. There are other
places in this file that use errno. How about I make that a separate
patch and catch all of them at once to use perror() as a follow-up
change? That way I fix all at once without adding more changes to
this patch.

Sounds good.