Re: [PATCH v4 1/5] drm/rockchip: Add basic drm driver

On 2014年09月24日 19:20, Daniel Vetter wrote:

On Wed, Sep 24, 2014 at 11:31 AM, Mark yao [off-list ref] wrote:

quoted

On 2014年09月24日 16:20, Daniel Vetter wrote:

quoted

On Mon, Sep 22, 2014 at 06:48:54PM +0800, Mark yao wrote:

quoted

This patch adds the basic structure of a DRM Driver for Rockchip Socs.

Signed-off-by: Mark yao <redacted>
---
Changes in v2:
- use the component framework to defer main drm driver probe
    until all VOP devices have been probed.
- use dma-mapping API with ARM_DMA_USE_IOMMU, create dma mapping by
    master device and each vop device can shared the drm dma mapping.
- use drm_crtc_init_with_planes and drm_universal_plane_init.
- remove unnecessary middle layers.
- add cursor set, move funcs to rockchip drm crtc.
- use vop reset at first init
- reference framebuffer when used and unreference when swap out vop

Changes in v3:
- change "crtc->fb" to "crtc->primary-fb"
Adviced by Daniel Vetter
- init cursor plane with universal api, remove unnecessary cursor
set,move

Changes in v4:
Adviced by David Herrmann
- remove drm_platform_*() usage, use register drm device directly.
Adviced by Rob Clark
- remove special mmap ioctl, do userspace mmap with normal mmap() or mmap
offset

   drivers/gpu/drm/Kconfig                       |    2 +
   drivers/gpu/drm/Makefile                      |    1 +
   drivers/gpu/drm/rockchip/Kconfig              |   19 +
   drivers/gpu/drm/rockchip/Makefile             |   10 +
   drivers/gpu/drm/rockchip/rockchip_drm_drv.c   |  524 ++++++++++
   drivers/gpu/drm/rockchip/rockchip_drm_drv.h   |  120 +++
   drivers/gpu/drm/rockchip/rockchip_drm_fb.c    |  201 ++++
   drivers/gpu/drm/rockchip/rockchip_drm_fb.h    |   28 +
   drivers/gpu/drm/rockchip/rockchip_drm_fbdev.c |  231 +++++
   drivers/gpu/drm/rockchip/rockchip_drm_fbdev.h |   20 +
   drivers/gpu/drm/rockchip/rockchip_drm_gem.c   |  404 ++++++++
   drivers/gpu/drm/rockchip/rockchip_drm_gem.h   |   72 ++
   drivers/gpu/drm/rockchip/rockchip_drm_vop.c   | 1372
+++++++++++++++++++++++++
   drivers/gpu/drm/rockchip/rockchip_drm_vop.h   |  187 ++++
   include/uapi/drm/rockchip_drm.h               |   75 ++

uapi is still here ... Was this an oversight?
-Daniel

Hi, Daniel
this version is old, newest is v5. and I remove uapi at v5.
you can see v5 patch at:
https://lkml.org/lkml/2014/9/23/1061
thanks

This version doesn't seem to be cc'ed to dri-devel, at least it didn't
yet show up. Can you please double-check?

actually I cc the v5 version to dri-devel@lists.freedesktop.org.
and we can found the patch at 
https://patchwork.kernel.org/patch/4967501/( *Project*: dri-devel)

Thanks, Daniel