Shuah Khan [off-list ref] writes:
On 09/23/2014 04:41 PM, Eric W. Biederman wrote:
quoted
Shuah Khan [off-list ref] writes:
quoted
Change mount test to use kselftest framework to report
test results.
Nacked-by: "Eric W. Biederman" [off-list ref]
I am curious did you even run these tests? I can't possibly see how
the tests would have passed with this change. At the very least you
have taken this test from linear to exponential time complexity.
Oops. I meant to drop this commit from the series. Sorry for the
noise.
No problem. Except for the unnecessary semantic change the rest of the
change looked fine. I just wanted to make certain you didn't break my
test by accident.
Eric
On 09/23/2014 05:07 PM, Eric W. Biederman wrote:
Shuah Khan [off-list ref] writes:
quoted
On 09/23/2014 04:41 PM, Eric W. Biederman wrote:
quoted
Shuah Khan [off-list ref] writes:
quoted
Change mount test to use kselftest framework to report
test results.
Nacked-by: "Eric W. Biederman" [off-list ref]
I am curious did you even run these tests? I can't possibly see how
the tests would have passed with this change. At the very least you
have taken this test from linear to exponential time complexity.
Oops. I meant to drop this commit from the series. Sorry for the
noise.
No problem. Except for the unnecessary semantic change the rest of the
change looked fine. I just wanted to make certain you didn't break my
test by accident.
Thanks for catching it. The results didn't look right and I meant
to delay this change for later after another round of testing.
I will fix it without the unnecessary change and send it out
separately.
thanks,
-- Shuah
--
Shuah Khan
Sr. Linux Kernel Developer
Samsung Research America (Silicon Valley)
shuahkh-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org | (970) 217-8978