Re: [PATCH] selftests/memfd: Run test on all architectures

From
David Herrmann <hidden>
Date
2014-09-17 12:28:04
Also in
lkml
Reply to
Pranith Kumar, 2014-09-15
Hi

On Tue, Sep 16, 2014 at 12:59 AM, Pranith Kumar [off-list ref] wrote:
Remove the dependence on x86 to run the memfd test. Verfied on 32-bit powerpc.

Signed-off-by: Pranith Kumar <redacted>
Now that most archs have __NR_memfd_create, this is:

Reviewed-by: David Herrmann <redacted>

Thanks
David
quoted hunk ↗ jump to hunk
---
 tools/testing/selftests/memfd/Makefile | 21 ---------------------
 1 file changed, 21 deletions(-)
diff --git a/tools/testing/selftests/memfd/Makefile b/tools/testing/selftests/memfd/Makefile
index ad4ab01..b80cd10 100644
--- a/tools/testing/selftests/memfd/Makefile
+++ b/tools/testing/selftests/memfd/Makefile
@@ -1,38 +1,17 @@
-uname_M := $(shell uname -m 2>/dev/null || echo not)
-ARCH ?= $(shell echo $(uname_M) | sed -e s/i.86/i386/)
-ifeq ($(ARCH),i386)
-       ARCH := x86
-endif
-ifeq ($(ARCH),x86_64)
-       ARCH := x86
-endif
-
 CFLAGS += -D_FILE_OFFSET_BITS=64
-CFLAGS += -I../../../../arch/x86/include/generated/uapi/
-CFLAGS += -I../../../../arch/x86/include/uapi/
 CFLAGS += -I../../../../include/uapi/
 CFLAGS += -I../../../../include/

 all:
-ifeq ($(ARCH),x86)
        gcc $(CFLAGS) memfd_test.c -o memfd_test
-else
-       echo "Not an x86 target, can't build memfd selftest"
-endif

 run_tests: all
-ifeq ($(ARCH),x86)
        gcc $(CFLAGS) memfd_test.c -o memfd_test
-endif
        @./memfd_test || echo "memfd_test: [FAIL]"

 build_fuse:
-ifeq ($(ARCH),x86)
        gcc $(CFLAGS) fuse_mnt.c `pkg-config fuse --cflags --libs` -o fuse_mnt
        gcc $(CFLAGS) fuse_test.c -o fuse_test
-else
-       echo "Not an x86 target, can't build memfd selftest"
-endif

 run_fuse: build_fuse
        @./run_fuse_test.sh || echo "fuse_test: [FAIL]"
--
2.1.0
Thread (6 messages) 6 messages, 3 authors, last reply 2014-09-17
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help