Re: [RESEND PATCH v3 1/6] charger: max14577: Add support for MAX77836 charger

On śro, 2014-08-27 at 14:52 +0100, Lee Jones wrote:

On Wed, 27 Aug 2014, Krzysztof Kozlowski wrote:

quoted

Add support for MAX77836 charger to the max14577 driver. The MAX77836
charger is almost the same as 14577 model except:
 - No dead-battery detection;
 - Support for special charger (like in MAX77693);
 - Support for DX over-voltage protection (like in MAX77693);
 - Lower values of charging current (two times lower current for
   slow/fast charge, much lower EOC current);
 - Slightly different values in ChgTyp field of STATUS2 register. On
   MAX14577 0x6 is reserved and 0x7 dead battery. On the MAX77836 the
   0x6 means special charger and 0x7 is reserved. Regardless of these
   differences the driver maps them to one enum max14577_muic_charger_type.

Signed-off-by: Krzysztof Kozlowski <redacted>
Cc: Kyungmin Park <redacted>
Cc: Anton Vorontsov <redacted>
Cc: Dmitry Eremin-Solenikov <redacted>
Cc: David Woodhouse <redacted>
Acked-by: Lee Jones <redacted>
---
 drivers/power/Kconfig                |  4 +-
 drivers/power/max14577_charger.c     | 77 +++++++++++++++++++++++++++++-------
 include/linux/mfd/max14577-private.h | 54 ++++++++++++++++++-------

Not quite so important here, but better to break these out too.  We
can arrange ourselves to that the set can go in together.  Just make
sure it's bisectable.

Are you sure? This will result in a patch which adds some
code/symbols/defines used only by next (future) patch. Independent apply
of such patch still won't make any sense because there won't be any user
of this code.


Best regards,
Krzysztof