Re: [PATCH v10 0/11] seccomp: add thread sync ability
From: Kees Cook <hidden>
Date: 2014-07-11 17:55:36
Also in:
linux-arch, linux-arm-kernel, linux-mips, lkml
From: Kees Cook <hidden>
Date: 2014-07-11 17:55:36
Also in:
linux-arch, linux-arm-kernel, linux-mips, lkml
On Fri, Jul 11, 2014 at 9:49 AM, Oleg Nesterov [off-list ref] wrote:
On 07/10, Kees Cook wrote:quoted
This adds the ability for threads to request seccomp filter synchronization across their thread group (at filter attach time). For example, for Chrome to make sure graphic driver threads are fully confined after seccomp filters have been attached. To support this, locking on seccomp changes via thread-group-shared sighand lock is introduced, along with refactoring of no_new_privs. Races with thread creation are handled via delayed duplication of the seccomp task struct field and cred_guard_mutex. This includes a new syscall (instead of adding a new prctl option), as suggested by Andy Lutomirski and Michael Kerrisk.I do not not see any problems in this version,
Awesome! Thank you for all the reviews. :) If Andy and Michael are happy with this too, I think this is in good shape. \o/ -Kees
Reviewed-by: Oleg Nesterov <oleg@redhat.com>
-- Kees Cook Chrome OS Security