Re: [PATCH v9] mm: support madvise(MADV_FREE)
flat view
From: Kirill A. Shutemov <hidden>
Date: 2014-07-01 14:51:31
Also in:
linux-mm, lkml
On Tue, Jul 01, 2014 at 09:36:15AM +0900, Minchan Kim wrote:
quoted hunk ↗ jump to hunk
+ do { + /* + * XXX: We can optimize with supporting Hugepage free + * if the range covers. + */ + next = pmd_addr_end(addr, end); + if (pmd_trans_huge(*pmd)) + split_huge_page_pmd(vma, addr, pmd);
Could you implement proper THP support before upstreaming the feature? It shouldn't be a big deal.
quoted hunk ↗ jump to hunk
+ /* + * Here there can be other concurrent MADV_DONTNEED or + * trans huge page faults running, and if the pmd is + * none or trans huge it can change under us. This is + * because MADV_LAZYFREE holds the mmap_sem in read + * mode. + */ + if (pmd_none_or_trans_huge_or_clear_bad(pmd)) + goto next; + next = madvise_free_pte_range(tlb, vma, pmd, addr, next); +next: + cond_resched(); + } while (pmd++, addr = next, addr != end);
-- Kirill A. Shutemov -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>