Re: [RFC PATCH 2/2] block: virtio-blk: support multi virt queues per virtio-blk device
From: Rusty Russell <hidden>
Date: 2014-06-17 00:44:26
Also in:
lkml
From: Rusty Russell <hidden>
Date: 2014-06-17 00:44:26
Also in:
lkml
Ming Lei [off-list ref] writes:
+ if (virtio_has_feature(vdev, VIRTIO_BLK_F_MQ)) + err = virtio_cread_feature(vdev, VIRTIO_BLK_F_MQ, + struct virtio_blk_config, num_queues, + &num_vqs); + else + num_vqs = 1;
This is redundant: virtio_cread_feature() checks the feature.
So, either:
if (virtio_has_feature(vdev, VIRTIO_BLK_F_MQ))
virtio_cread(vdev, struct virtio_blk_config, num_queues,
&num_vqs);
else
num_vqs = 1;
Or:
err = virtio_cread_feature(vdev, VIRTIO_BLK_F_MQ,
struct virtio_blk_config, num_queues,
&num_vqs);
if (err)
num_vqs = 1;
Otherwise, the patch looks pretty straight-forward.
Cheers,
Rusty.